[PATCH] D51080: litsupport/remote: Work without shared filesystem
Matthias Braun via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 22 15:33:14 PDT 2018
MatzeB added a comment.
In https://reviews.llvm.org/D51080#1210083, @Meinersbur wrote:
> In https://reviews.llvm.org/D51080#1209955, @MatzeB wrote:
>
> > In https://reviews.llvm.org/D51080#1209934, @Meinersbur wrote:
> >
> > > 1. cmake builddir for cross-compilation
> > > 2. make/ninja
> > > 3. rsync pushes test-suite builddir to target
> > > 4. llvm-lit locale, but run every command on remote using ssh
> > > 5. including fpmc/VALIDATE step in *.test (SPEC2017 also uses `llvm_add_host_executable`)
> >
> >
> > The `VERIFY:` steps in the scripts are run remotely as well.
>
>
> `PREPARE:` and `METRIC` as well?
Yes `PREPARE:` is modified as well, and I just realized `METRIC:` should be modified too but is still TODO :)
>> I hope that takes part of the spec2017 validation things[*]
>
> Yes, it should. As you mentioned, it will require the reference output on the remote as well.
> It also means, we don't need `llvm_add_host_executable` anymore, which I consider a good thing.
ah indeed, that is a nice side effect.
Repository:
rT test-suite
https://reviews.llvm.org/D51080
More information about the llvm-commits
mailing list