[PATCH] D50837: [x86/SLH] Teach SLH to harden against the "ret2spec" attack by implementing the proposed mitigation technique described in the original design document.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 22 15:12:47 PDT 2018


chandlerc updated this revision to Diff 162069.
chandlerc added a comment.

Update fixing a bug where we would try to use the red-zone mechanism to extract
the return address for functions that return twice like setjmp. This, somewhat
unsurprisingly (in retrospect) doesn't work at all. Instead, force switching
back to the simpler form where we compute the return address directly ahead of
time.


Repository:
  rL LLVM

https://reviews.llvm.org/D50837

Files:
  llvm/docs/SpeculativeLoadHardening.md
  llvm/lib/Target/X86/X86SpeculativeLoadHardening.cpp
  llvm/test/CodeGen/X86/speculative-load-hardening-call-and-ret.ll
  llvm/test/CodeGen/X86/speculative-load-hardening-indirect.ll
  llvm/test/CodeGen/X86/speculative-load-hardening.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50837.162069.patch
Type: text/x-patch
Size: 54881 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180822/5516fe64/attachment.bin>


More information about the llvm-commits mailing list