[PATCH] D49672: [CMake] Honor LLVM_EXTERNAL_<proj>_SOURCE_DIR

David Greene via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 22 13:50:32 PDT 2018


greened added a comment.

In https://reviews.llvm.org/D49672#1199990, @smeenai wrote:

> This is pretty confusing, but there's both `LLVM_ENABLE_PROJECTS`, which assumes the side-by-side layout, and `LLVM_EXTERNAL_PROJECTS`, which assumes the corresponding `SOURCE_DIR` variables will be set. It sounds like `LLVM_EXTERNAL_PROJECTS` is what you want for your use case.


Right.  Fixing the confusion is the point of this patch.  If both are specified, the explicitly-given paths should be honored.


Repository:
  rL LLVM

https://reviews.llvm.org/D49672





More information about the llvm-commits mailing list