[PATCH] D49034: [WebAssembly] Move/clone DBG_VALUE during WebAssemblyRegStackify pass

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 22 13:31:10 PDT 2018


dschuff added a comment.

Otherwise LGTM, although I'm not an expert in DebugInfo either.



================
Comment at: lib/Target/WebAssembly/WebAssemblyRegStackify.cpp:470
+                            MachineBasicBlock &MBB, MachineRegisterInfo &MRI) {
+  for (MachineRegisterInfo::reg_iterator RI = MRI.reg_begin(Reg),
+                                         RE = MRI.reg_end();
----------------
I think this can just be something like `for (const auto &Op : MRI.reg_operands(Reg))`  (and below)


Repository:
  rL LLVM

https://reviews.llvm.org/D49034





More information about the llvm-commits mailing list