[llvm] r340436 - [CMake] Remove unneeded and outdated policy

Chris Bieneman via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 22 11:41:14 PDT 2018


Author: cbieneman
Date: Wed Aug 22 11:41:14 2018
New Revision: 340436

URL: http://llvm.org/viewvc/llvm-project?rev=340436&view=rev
Log:
[CMake] Remove unneeded and outdated policy

This was needed way back because we didn't properly handle that the SOURCES property of a target could have things that weren't source files to compile. Almost 2 years ago Takumi fixed that, and now CMake is throwing warnings that we should get off the old behavior.

Modified:
    llvm/trunk/CMakeLists.txt

Modified: llvm/trunk/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/CMakeLists.txt?rev=340436&r1=340435&r2=340436&view=diff
==============================================================================
--- llvm/trunk/CMakeLists.txt (original)
+++ llvm/trunk/CMakeLists.txt Wed Aug 22 11:41:14 2018
@@ -2,13 +2,6 @@
 
 cmake_minimum_required(VERSION 3.4.3)
 
-# CMake 3.1 and higher include generator expressions of the form
-# $<TARGETLIB:obj> in the SOURCES property.  These need to be
-# stripped everywhere that access the SOURCES property, so we just
-# defer to the OLD behavior of not including generator expressions
-# in the output for now.
-cmake_policy(SET CMP0051 OLD)
-
 if(POLICY CMP0068)
   cmake_policy(SET CMP0068 NEW)
   set(CMAKE_BUILD_WITH_INSTALL_NAME_DIR ON)




More information about the llvm-commits mailing list