[PATCH] D51092: [LibCalls] Added returned attribute to libcalls
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 22 11:38:46 PDT 2018
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM with nits.
================
Comment at: lib/Transforms/Utils/BuildLibCalls.cpp:162
case LibFunc_strncat:
- case LibFunc_strncpy:
+ Changed |= setReturnedArg(F, 0);
+ case LibFunc_stpcpy:
----------------
Please explicitly mark fallthrough using LLVM_FALLTHROUGH.
================
Comment at: lib/Transforms/Utils/BuildLibCalls.cpp:276
+ case LibFunc_memmove:
+ Changed |= setReturnedArg(F, 0);
case LibFunc_mempcpy:
----------------
Please explicitly mark fallthrough using LLVM_FALLTHROUGH.
Repository:
rL LLVM
https://reviews.llvm.org/D51092
More information about the llvm-commits
mailing list