[llvm] r340433 - [WebAssembly] Add hasSideEffects flag to catch instructions

Heejin Ahn via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 22 11:22:46 PDT 2018


Author: aheejin
Date: Wed Aug 22 11:22:45 2018
New Revision: 340433

URL: http://llvm.org/viewvc/llvm-project?rev=340433&view=rev
Log:
[WebAssembly] Add hasSideEffects flag to catch instructions

Summary:
`catch` instruction certainly has rather huge side effects and the flag
was missing. At the moment this does not change any unit tests we
currently have.

Reviewers: dschuff

Subscribers: sbc100, jgravelle-google, sunfish, llvm-commits

Differential Revision: https://reviews.llvm.org/D50919

Modified:
    llvm/trunk/lib/Target/WebAssembly/WebAssemblyInstrControl.td

Modified: llvm/trunk/lib/Target/WebAssembly/WebAssemblyInstrControl.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/WebAssembly/WebAssemblyInstrControl.td?rev=340433&r1=340432&r2=340433&view=diff
==============================================================================
--- llvm/trunk/lib/Target/WebAssembly/WebAssemblyInstrControl.td (original)
+++ llvm/trunk/lib/Target/WebAssembly/WebAssemblyInstrControl.td Wed Aug 22 11:22:45 2018
@@ -172,7 +172,7 @@ defm END_TRY : NRI<(outs), (ins), [], "e
 } // Uses = [VALUE_STACK], Defs = [VALUE_STACK]
 
 // Catching an exception: catch / catch_all
-let hasCtrlDep = 1 in {
+let hasCtrlDep = 1, hasSideEffects = 1 in {
 defm CATCH_I32 : I<(outs I32:$dst), (ins i32imm:$tag),
                    (outs), (ins i32imm:$tag),
                    [(set I32:$dst, (int_wasm_catch imm:$tag))],




More information about the llvm-commits mailing list