[PATCH] D50629: AMDGPU: Fix getInstSizeInBytes

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUMCInstLower.cpp:320
 
+    LLVM_DEBUG(checkInstSize(*MI, TmpInst, STI, OutContext));
+
----------------
arsenm wrote:
> arsenm wrote:
> > I strongly dislike assertion checks inside debug printing
> Why can't you just assert after the instruction is emitted normally?
You could always put this under an EXPENSIVE_TEST checks or whatever it's called, then at least the bots will be testing it


Repository:
  rL LLVM

https://reviews.llvm.org/D50629