[PATCH] D51030: [AArch64] Optimise load(adr address) to ldr address

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.



> Thanks for looking. What is our usual response with issues like this? Is it OK for this to go ahead, as it can be used fine in some linkers. I could put it behind a flag I think, so that users have the option to turn it off (although that might not be very obvious..)

I think it depends on the context. For example:

- How many existing builds is it going to break?
- How easy would it be to backport the fix in binutils if it were important enough to do so?
- Are there alternatives to binutils available?
- Does the same fault exist when compiling the file with GCC?

In this particular case I think:

- There are no existing clients of the tiny code model, so no existing builds to break.
- The fix is fairly recent, AArch64 specific so it could be backported if necessary.
- In theory LLD is an option if we get support in for the same clang release.
- If it doesn't work on GCC it probably means very few people are using the feature on linux.

In summary I think the impact would be low enough that it isn't worth worrying about it.


https://reviews.llvm.org/D51030