[PATCH] D50894: Pull google/benchmark library to the LLVM tree

[Dean Michael Berris via Phabricator via llvm-commits]

dberris added inline comments.


================
Comment at: llvm/CMakeLists.txt:501
 
+option(LLVM_BUILD_BENCHMARKS "Generate build targets for the LLVM benchmarks." OFF)
+
----------------
kbobyrev wrote:
> dberris wrote:
> > Is there a way to run these automatically as well, similar to the split between the `LLVM_BUILD_TESTS` and `LLVM_INCLUDE_TESTS`?
> Do I understand correctly that `LLVM_INCLUDE_TESTS` adds tests to the list of default targets while `LLVM_BUILD_TESTS` simply enables/disables them?
> 
> Would you suggest the same split for benchmarks? I thought that for the first iteration we might want to leave the benchmarks "invisible" for the most users, but I can totally see how excluding them from the global list of build targets (which is the case now) can be hard for people to actually start running benchmarks.
Yes, I'd suggest having the split in there. It's one thing to build the benchmarks (as we have build bots that do a "fast" build) and another to run them. I don't yet see whether we will have performance runners collecting data as with the test-suite nightly runners, but even if we don't have those, at least having an option for just building the benchmarks being different from running them will be useful.


https://reviews.llvm.org/D50894