[PATCH] D48013: TableGen/SearchableTables: Support more generic enums and tables

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 22 04:29:04 PDT 2018


nhaehnle marked an inline comment as done.
nhaehnle added inline comments.


================
Comment at: llvm/trunk/utils/TableGen/SearchableTableEmitter.cpp:437
+      OS << "      if (LHS." << Field.Name << " > RHS." << Field.Name << ")\n";
+      OS << "        return false;\n";
+    }
----------------
RKSimon wrote:
> @nhaehnle We are still seeing signed/unsigned warnings on MSVC builds - please fix this.
> 
> http://lab.llvm.org:8011/builders/lld-x86_64-win7/builds/25901/steps/build%20lld/logs/warnings%20%282%29
Please see D51097.


Repository:
  rL LLVM

https://reviews.llvm.org/D48013





More information about the llvm-commits mailing list