[llvm] r340392 - [mips] Handle missing CondCodes

Stefan Maksimovic via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 22 02:34:44 PDT 2018


Author: smaksimovic
Date: Wed Aug 22 02:34:44 2018
New Revision: 340392

URL: http://llvm.org/viewvc/llvm-project?rev=340392&view=rev
Log:
[mips] Handle missing CondCodes

Add patterns for unhandled CondCode enumerables:
SETEQ, SETGE, SETGT, SETLE, SETLT, SETNE.

Stated at the ISD::CondCode enum declaration:
`All of these (except for the 'always folded ops')
should be handled for floating point.`

Add patterns which use these nodes, same as corresponding
'ordered' CondCode nodes.

Referring to 'Ordered means that neither operand is a QNAN'
we assume it is safe to match ex. SETLT node to the same
instruction as SETOLT.

Differential Revision: https://reviews.llvm.org/D50757

Added:
    llvm/trunk/test/CodeGen/Mips/msa/cc_without_nan.ll
Modified:
    llvm/trunk/lib/Target/Mips/MipsMSAInstrInfo.td

Modified: llvm/trunk/lib/Target/Mips/MipsMSAInstrInfo.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsMSAInstrInfo.td?rev=340392&r1=340391&r2=340392&view=diff
==============================================================================
--- llvm/trunk/lib/Target/Mips/MipsMSAInstrInfo.td (original)
+++ llvm/trunk/lib/Target/Mips/MipsMSAInstrInfo.td Wed Aug 22 02:34:44 2018
@@ -107,6 +107,18 @@ class vfsetcc_type<ValueType ResTy, Valu
           (ResTy (vfsetcc (OpTy node:$lhs), (OpTy node:$rhs), CC))>;
 
 // ISD::SETFALSE cannot occur
+def vfseteq_v4f32 : vfsetcc_type<v4i32, v4f32, SETEQ>;
+def vfseteq_v2f64 : vfsetcc_type<v2i64, v2f64, SETEQ>;
+def vfsetge_v4f32 : vfsetcc_type<v4i32, v4f32, SETGE>;
+def vfsetge_v2f64 : vfsetcc_type<v2i64, v2f64, SETGE>;
+def vfsetgt_v4f32 : vfsetcc_type<v4i32, v4f32, SETGT>;
+def vfsetgt_v2f64 : vfsetcc_type<v2i64, v2f64, SETGT>;
+def vfsetle_v4f32 : vfsetcc_type<v4i32, v4f32, SETLE>;
+def vfsetle_v2f64 : vfsetcc_type<v2i64, v2f64, SETLE>;
+def vfsetlt_v4f32 : vfsetcc_type<v4i32, v4f32, SETLT>;
+def vfsetlt_v2f64 : vfsetcc_type<v2i64, v2f64, SETLT>;
+def vfsetne_v4f32 : vfsetcc_type<v4i32, v4f32, SETNE>;
+def vfsetne_v2f64 : vfsetcc_type<v2i64, v2f64, SETNE>;
 def vfsetoeq_v4f32 : vfsetcc_type<v4i32, v4f32, SETOEQ>;
 def vfsetoeq_v2f64 : vfsetcc_type<v2i64, v2f64, SETOEQ>;
 def vfsetoge_v4f32 : vfsetcc_type<v4i32, v4f32, SETOGE>;
@@ -4038,3 +4050,20 @@ def : MSAPat<
          (SPLAT_D v2f64:$ws,
            (COPY_TO_REGCLASS (i32 (EXTRACT_SUBREG i64:$idx, sub_32)), GPR32)),
          sub_64))>;
+
+def : MSAPat<(vfseteq_v4f32 MSA128WOpnd:$a, MSA128WOpnd:$b),
+             (FCEQ_W MSA128WOpnd:$a, MSA128WOpnd:$b)>;
+def : MSAPat<(vfseteq_v2f64 MSA128DOpnd:$a, MSA128DOpnd:$b),
+             (FCEQ_D MSA128DOpnd:$a, MSA128DOpnd:$b)>;
+def : MSAPat<(vfsetle_v4f32 MSA128WOpnd:$a, MSA128WOpnd:$b),
+             (FCLE_W MSA128WOpnd:$a, MSA128WOpnd:$b)>;
+def : MSAPat<(vfsetle_v2f64 MSA128DOpnd:$a, MSA128DOpnd:$b),
+             (FCLE_D MSA128DOpnd:$a, MSA128DOpnd:$b)>;
+def : MSAPat<(vfsetlt_v4f32 MSA128WOpnd:$a, MSA128WOpnd:$b),
+             (FCLT_W MSA128WOpnd:$a, MSA128WOpnd:$b)>;
+def : MSAPat<(vfsetlt_v2f64 MSA128DOpnd:$a, MSA128DOpnd:$b),
+             (FCLT_D MSA128DOpnd:$a, MSA128DOpnd:$b)>;
+def : MSAPat<(vfsetne_v4f32 MSA128WOpnd:$a, MSA128WOpnd:$b),
+             (FCNE_W MSA128WOpnd:$a, MSA128WOpnd:$b)>;
+def : MSAPat<(vfsetne_v2f64 MSA128DOpnd:$a, MSA128DOpnd:$b),
+             (FCNE_D MSA128DOpnd:$a, MSA128DOpnd:$b)>;

Added: llvm/trunk/test/CodeGen/Mips/msa/cc_without_nan.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Mips/msa/cc_without_nan.ll?rev=340392&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/Mips/msa/cc_without_nan.ll (added)
+++ llvm/trunk/test/CodeGen/Mips/msa/cc_without_nan.ll Wed Aug 22 02:34:44 2018
@@ -0,0 +1,63 @@
+; RUN: llc -mtriple mips64-unknown-linux -mcpu=mips64r5 -mattr=+msa < %s | FileCheck %s
+
+; The fcmp fast flag will result in conversion from
+; setolt, setoeq, setole, setone to
+; setlt, seteq, setle, setne nodes.
+; Test that the latter nodes are matched to the same instructions as the former.
+
+define <2 x i1> @testlt_v2f64(<2 x double> %a, <2 x double> %b) {
+start:
+  %0 = fcmp fast olt <2 x double> %a, %b
+  ; CHECK: fclt.d
+  ret <2 x i1> %0
+}
+
+define <4 x i1>  @testlt_v4f32(<4 x float> %a, <4 x float> %b) {
+start:
+  %0 = fcmp fast olt <4 x float> %a, %b
+  ; CHECK: fclt.w
+  ret <4 x i1> %0
+}
+
+define <2 x i1> @testeq_v2f64(<2 x double> %a, <2 x double> %b) {
+start:
+  %0 = fcmp fast oeq <2 x double> %a, %b
+  ; CHECK: fceq.d
+  ret <2 x i1> %0
+}
+
+define <4 x i1> @testeq_v4f32(<4 x float> %a, <4 x float> %b) {
+start:
+  %0 = fcmp fast oeq <4 x float> %a, %b
+  ; CHECK: fceq.w
+  ret <4 x i1> %0
+}
+
+define <2 x i1> @testle_v2f64(<2 x double> %a, <2 x double> %b) {
+start:
+  %0 = fcmp fast ole <2 x double> %a, %b
+  ; CHECK: fcle.d
+  ret <2 x i1> %0
+}
+
+define <4 x i1> @testle_v4f32(<4 x float> %a, <4 x float> %b) {
+start:
+  %0 = fcmp fast ole <4 x float> %a, %b
+  ; CHECK: fcle.w
+  ret <4 x i1> %0
+}
+
+define <2 x i1> @testne_v2f64(<2 x double> %a, <2 x double> %b) {
+start:
+  %0 = fcmp fast one <2 x double> %a, %b
+  ; CHECK: fcne.d
+  ret <2 x i1> %0
+}
+
+define <4 x i1> @testne_v4f32(<4 x float> %a, <4 x float> %b) {
+start:
+  %0 = fcmp fast one <4 x float> %a, %b
+  ; CHECK: fcne.w
+  ret <4 x i1> %0
+}
+




More information about the llvm-commits mailing list