[PATCH] D51002: [Tooling] Allow -flto flags and filter out -Wa, flags

[Eric Liu via Phabricator via llvm-commits]

ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D51002#1208152, @chh wrote:

> I tested with clang-tidy test.cpp -- -c -Iinc -flto,
>  and found that in Driver.cpp:getTool Inputs has one action equal to
>  BackendJobClass (without -flto) or CompileJobClass (with -flto).
>
> When in CompilationDatabase:stripPositionalArgs, the Jobs has only one
>  AssembleJobClass (without -flto) or BackendJobClass (with -flto).
>  It is confusing to change the Backend/Compile to Assemble/Backend.
>  However, I have not seen multiple jobs yet. 
>  Do you have a test case that could trigger multiple jobs with or without -flto?


Not really. I'm not familiar with backend jobs and just wanted to ask for clarification. Thanks!



================
Comment at: lib/Tooling/CompilationDatabase.cpp:172
 
     default:
       // Don't care about others
----------------
Do we also need to something for BackendJob here?


https://reviews.llvm.org/D51002