[PATCH] D50435: [Inliner] Attribute callsites with inline remarks

Yevgeny Rouban via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 22 01:31:18 PDT 2018


yrouban marked 4 inline comments as done.
yrouban added inline comments.


================
Comment at: lib/Transforms/IPO/Inliner.cpp:673
         if (!IR) {
+          setInlineRemark(CS, std::string(IR) + "; " + inlineCostStr(*OIC));
           ORE.emit([&]() {
----------------
tejohnson wrote:
> I'm not sure what this ends up looking like - can you add a case with this string to your test?
You are right, I forgot to change the return type of InlineCallIfPossible() from //bool// to //InlineResult//.


https://reviews.llvm.org/D50435





More information about the llvm-commits mailing list