[PATCH] D50388: Respect PYTHONPATH

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 22 01:27:25 PDT 2018


delcypher added inline comments.


================
Comment at: utils/lit/tests/lit.cfg:39
+pythonpath_list = [lit_path]
+if 'PYTHONPATH' in os.environ:
+    pythonpath_list.append(os.environ['PYTHONPATH'])
----------------
You should add a comment above the `if 'PYTHONPATH'` explaining why this is being here because it looks like the `Required because some tests import the lit module` comment is describing the entire block of code, whereas it actually only describes the very first statement (`pythonpath_list = [lit_path]`).


Repository:
  rL LLVM

https://reviews.llvm.org/D50388





More information about the llvm-commits mailing list