[PATCH] D51003: Allow demangler's node allocator to fail, and bail out of the entire demangling process when it does. Use this to support a "lookup" query for the mangling canonicalizer that does not create new nodes.
Erik Pilkington via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 22 00:53:44 PDT 2018
erik.pilkington added a comment.
It seems like we would need to add a lot more nullptr checks in order to really support this then this patch does. One potential workaround is to add a subclass of Node in ItaniumManglingCanonicalizer.cpp that serves as the canonical 'sentinel' node. We could just hand that out whenever we would otherwise allocate anything, and ignore the results of parse() if we ever did. I think that would probably maybe work.
Repository:
rL LLVM
https://reviews.llvm.org/D51003
More information about the llvm-commits
mailing list