[PATCH] D50494: [LLD] Reserve memory in implicitly set LMARegions

[Konstantin Schwarz via Phabricator via llvm-commits]

kschwarz added inline comments.


================
Comment at: ELF/LinkerScript.cpp:824
+  if (Ctx->LMARegion && !areFlagsCompatible(Ctx->LMARegion, Sec))
+    warn("requested to locate " + Sec->Name + " into lma region with"
+         " incompatible flags");
----------------
grimar wrote:
> I think:
> 1) LMA perhaps should be uppercase in the error message.
> 2) Would be nice to include memory region name to this warning.
After a second thought, I'm not sure if this warning really makes sense.
Initialized data will be copied to RAM at runtime, but has to be loaded to read-only memory. In that case, the flags will obviously not be compatible, and the warning will be confusing. 



Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D50494