[PATCH] D51078: Reduce the memory footprint of dsymutil. (NFC)

Frederic Riss via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 21 20:20:46 PDT 2018


friss accepted this revision.
friss added a comment.
This revision is now accepted and ready to land.

Thanks, this LGTM



================
Comment at: tools/dsymutil/DwarfLinker.cpp:2471
+                                LinkContext.Ranges, OffsetsStringPool,
+                                UniquingStringPool, ODRContexts, UnitID);
     }
----------------
aprantl wrote:
> friss wrote:
> > Here UnitID is always the same in this loop. Pretty sure that's bad.
> UnitDie is an inout parameter, it is being incremented by `loadClangModule()` if it creates a new module.
I see, thanks.


https://reviews.llvm.org/D51078





More information about the llvm-commits mailing list