[PATCH] D51060: [gold] -thinlto-object-suffix-replace: don't append new suffix if path does not end with old suffix

[Fangrui Song via Phabricator via llvm-commits]

MaskRay updated this revision to Diff 161869.
MaskRay edited the summary of this revision.
MaskRay removed subscribers: mehdi_amini, eraman, steven_wu.
MaskRay added a comment.

Update summary with arc diff --edit --verbatim


Repository:
  rL LLVM

https://reviews.llvm.org/D51060

Files:
  test/tools/gold/X86/thinlto_object_suffix_replace.ll
  tools/gold/gold-plugin.cpp


Index: tools/gold/gold-plugin.cpp
===================================================================
--- tools/gold/gold-plugin.cpp
+++ tools/gold/gold-plugin.cpp
@@ -667,13 +667,9 @@
 /// suffix matching \p OldSuffix with \p NewSuffix.
 static std::string getThinLTOObjectFileName(StringRef Path, StringRef OldSuffix,
                                             StringRef NewSuffix) {
-  if (OldSuffix.empty() && NewSuffix.empty())
-    return Path;
-  StringRef NewPath = Path;
-  NewPath.consume_back(OldSuffix);
-  std::string NewNewPath = NewPath;
-  NewNewPath += NewSuffix;
-  return NewNewPath;
+  if (Path.consume_back(OldSuffix))
+    return (Path + NewSuffix).str();
+  return Path;
 }
 
 // Returns true if S is valid as a C language identifier.
Index: test/tools/gold/X86/thinlto_object_suffix_replace.ll
===================================================================
--- test/tools/gold/X86/thinlto_object_suffix_replace.ll
+++ test/tools/gold/X86/thinlto_object_suffix_replace.ll
@@ -27,6 +27,17 @@
 ; RUN:    -shared %t1.thinlink.bc -o %t3
 ; RUN: diff %t1.o.thinlto.bc.orig %t1.o.thinlto.bc
 
+; If filename does not end with old suffix, no suffix change should occur,
+; so ".thinlto.bc" will simply be appended to the input file name.
+; RUN: rm -f %t1.thinlink.bc.thinlto.bc
+; RUN: %gold -plugin %llvmshlibdir/LLVMgold%shlibext \
+; RUN:    -m elf_x86_64 \
+; RUN:    --plugin-opt=thinlto \
+; RUN:    --plugin-opt=thinlto-index-only \
+; RUN:    --plugin-opt=thinlto-object-suffix-replace=".abc;.o" \
+; RUN:    -shared %t1.thinlink.bc -o /dev/null
+; RUN: ls %t1.thinlink.bc.thinlto.bc
+
 target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
 target triple = "x86_64-unknown-linux-gnu"
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51060.161869.patch
Type: text/x-patch
Size: 1725 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180822/4af59c80/attachment.bin>