[test-suite] r340360 - cmake/litsupport: Remove TEST_SUITE_REMOTE_USER + TEST_SUITE_REMOTE_PORT

[Matthias Braun via llvm-commits]

Author: matze
Date: Tue Aug 21 16:08:27 2018
New Revision: 340360

URL: http://llvm.org/viewvc/llvm-project?rev=340360&view=rev
Log:
cmake/litsupport: Remove TEST_SUITE_REMOTE_USER + TEST_SUITE_REMOTE_PORT

Nobody is using these and you can always set them (and many
other) options in your $HOME/.ssh/config file.

Modified:
    test-suite/trunk/CMakeLists.txt
    test-suite/trunk/lit.cfg
    test-suite/trunk/lit.site.cfg.in
    test-suite/trunk/litsupport/modules/remote.py

Modified: test-suite/trunk/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/test-suite/trunk/CMakeLists.txt?rev=340360&r1=340359&r2=340360&view=diff
==============================================================================
--- test-suite/trunk/CMakeLists.txt (original)
+++ test-suite/trunk/CMakeLists.txt Tue Aug 21 16:08:27 2018
@@ -64,9 +64,7 @@ endif()
 # Remote configuration (will be set in lit.site.cfg)
 set(TEST_SUITE_REMOTE_CLIENT "ssh" CACHE STRING "Remote execution client")
 set(TEST_SUITE_REMOTE_HOST "" CACHE STRING "Remote execution host")
-set(TEST_SUITE_REMOTE_USER "" CACHE STRING "Remote execution user")
-set(TEST_SUITE_REMOTE_PORT "" CACHE STRING "Remote execution port")
-mark_as_advanced(TEST_SUITE_REMOTE_CLIENT TEST_SUITE_REMOTE_USER TEST_SUITE_REMOTE_PORT)
+mark_as_advanced(TEST_SUITE_REMOTE_CLIENT)
 
 # Run Under configuration for RunSafely.sh (will be set in lit.site.cfg)
 set(TEST_SUITE_RUN_UNDER "" CACHE STRING "RunSafely.sh run-under (-u) parameter")

Modified: test-suite/trunk/lit.cfg
URL: http://llvm.org/viewvc/llvm-project/test-suite/trunk/lit.cfg?rev=340360&r1=340359&r2=340360&view=diff
==============================================================================
--- test-suite/trunk/lit.cfg (original)
+++ test-suite/trunk/lit.cfg Tue Aug 21 16:08:27 2018
@@ -22,7 +22,6 @@ config.name = 'test-suite'
 config.test_format = litsupport.test.TestSuiteTest()
 config.suffixes = ['.test']
 config.excludes = ['ABI-Testsuite']
-config.remote_flags = ""
 config.traditional_output = False
 config.single_source = False
 if 'SSH_AUTH_SOCK' in os.environ:

Modified: test-suite/trunk/lit.site.cfg.in
URL: http://llvm.org/viewvc/llvm-project/test-suite/trunk/lit.site.cfg.in?rev=340360&r1=340359&r2=340360&view=diff
==============================================================================
--- test-suite/trunk/lit.site.cfg.in (original)
+++ test-suite/trunk/lit.site.cfg.in Tue Aug 21 16:08:27 2018
@@ -4,8 +4,6 @@ config.test_source_root = "@CMAKE_BINARY
 config.test_exec_root = "@CMAKE_BINARY_DIR@"
 config.remote_client = "@TEST_SUITE_REMOTE_CLIENT@"
 config.remote_host = "@TEST_SUITE_REMOTE_HOST@"
-config.remote_user = "@TEST_SUITE_REMOTE_USER@"
-config.remote_port = "@TEST_SUITE_REMOTE_PORT@"
 config.run_under = "@TEST_SUITE_RUN_UNDER@"
 config.strip_tool = "@CMAKE_STRIP@"
 config.profile_generate = @TEST_SUITE_PROFILE_GENERATE@

Modified: test-suite/trunk/litsupport/modules/remote.py
URL: http://llvm.org/viewvc/llvm-project/test-suite/trunk/litsupport/modules/remote.py?rev=340360&r1=340359&r2=340360&view=diff
==============================================================================
--- test-suite/trunk/litsupport/modules/remote.py (original)
+++ test-suite/trunk/litsupport/modules/remote.py Tue Aug 21 16:08:27 2018
@@ -14,12 +14,6 @@ def _mutateCommandline(context, commandl
 
     config = context.config
     remote_commandline = config.remote_client
-    if config.remote_user:
-        remote_commandline += " -l %s" % config.remote_user
-    if config.remote_port:
-        remote_commandline += " -p %s" % config.remote_port
-    if config.remote_flags:
-        remote_commandline += config.remote_flags
     remote_commandline += " %s" % config.remote_host
     remote_commandline += " /bin/sh %s" % shfilename
     return remote_commandline