[PATCH] D50652: [libcxx] By default, do not use internal_linkage to hide symbols from the ABI

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 21 13:36:39 PDT 2018


Yes. But in practice nothing really changed though, right? It's just
going forward that things might break:

"This is a change in contract but not a change in behavior, since the
current implementation still allows linking TUs built with different
libc++ versions together."

On Fri, Aug 17, 2018 at 10:03 AM, Louis Dionne via Phabricator
<reviews at reviews.llvm.org> wrote:
> ldionne added a comment.
>
> In https://reviews.llvm.org/D50652#1202524, @hans wrote:
>
>> Thanks! Merged to 7.0 in r339882.
>
>
> Now that this has been done, I guess we need to document somewhere in the release notes that the default contract given by libc++ is changing in LLVM 7, right?
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D50652
>
>
>


More information about the llvm-commits mailing list