[PATCH] D50665: [LV][LAA] Vectorize loop invariant values stored into loop invariant address

[Anna Thomas via Phabricator via llvm-commits]

anna marked an inline comment as done.
anna added a comment.

In https://reviews.llvm.org/D50665#1206780, @Ayal wrote:

> In https://reviews.llvm.org/D50665#1200509, @anna wrote:
>
> >
>
>
> ...
>
> > Yes, the stores are scalarized. Identical replicas left as-is. Either passes such as load elimination can remove it, or we can clean it up in LV itself.
>
>
>
> - - by revisiting LoopVectorizationCostModel::collectLoopUniforms()?  ;-)


Right now, I just run instcombine after loop vectorization to clean up those unnecessary stores (and test cases make sure there's only one store left). Looks like there are other places in LV which relies on InstCombine as the clean up pass, so it may not be that bad after all? Thoughts?


Repository:
  rL LLVM

https://reviews.llvm.org/D50665