[PATCH] D51037: [CodeExtractor] Use 'normal destination' BB as insert point to store invoke results.

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 21 09:37:06 PDT 2018


davidxl added inline comments.


================
Comment at: lib/Transforms/Utils/CodeExtractor.cpp:933
+    // 'normal destination' BB.
+    if (auto *InvokeI = dyn_cast<InvokeInst>(OutI))
+      InsertPt = InvokeI->getNormalDest()->getFirstNonPHI();
----------------
Perhaps merge it as:

Instruction InsertPt;
if (auto *Invoke = ...) 
    InsertPt = ...
else
   InsertPt = OutI->getNextNode();


https://reviews.llvm.org/D51037





More information about the llvm-commits mailing list