[PATCH] D51033: [DWARF] Move error printing from DWARF classes to Support library. NFC.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In https://reviews.llvm.org/D51033#1207437, @jhenderson wrote:

> I'm not convinced "Display" is the right term for the message.


This should say "for the function name"



================
Comment at: include/llvm/DebugInfo/DWARF/DWARFDebugLine.h:252
                 const DWARFContext &Ctx, const DWARFUnit *U,
-                std::function<void(Error)> RecoverableErrorCallback = warn,
+                std::function<void(Error)> RecoverableErrorCallback = DisplayWarning,
                 raw_ostream *OS = nullptr);
----------------
jhenderson wrote:
> vleschuk wrote:
> > I know that this exceeds 80 chars per line, but that's what clang-format suggested.
> clang-format?
Sorry, you posted this whilst I was in the middle of writing the review!

Are you sure about this? It seems unusual, especially as there are ways to deal with it (indent the arguments less).


Repository:
  rL LLVM

https://reviews.llvm.org/D51033