[PATCH] D50894: Pull google/benchmark library to the LLVM tree

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 21 05:04:58 PDT 2018


lebedev.ri added inline comments.


================
Comment at: llvm/utils/benchmark/BUILD.bazel:2
+licenses(["notice"])
+
+config_setting(
----------------
Based on previous expirience (rL336635/rL336666), i think you want to drop the bazel stuff.


================
Comment at: llvm/utils/benchmark/tools/compare_bench.py:3
+"""
+compare_bench.py - Compare two benchmarks or their results and report the
+                   difference.
----------------
Consider not adding **this** script/file in the first place, only the `benchmark/tools/compare.py`, which superseded/replaced this one.
(`benchmark/tools/compare_bench.py` is already removed in gbench git master)


https://reviews.llvm.org/D50894





More information about the llvm-commits mailing list