[PATCH] D51027: [LLD][ELD] - Do not reject INFO output section type when used with a start address.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 21 03:51:08 PDT 2018


grimar added a comment.

In https://reviews.llvm.org/D51027#1207342, @bd1976llvm wrote:

> Hi George. Do we actually want this behaviour?
>
> The GNU linker docs states that these output section description type attributes are: " supported for backward compatibility, and are rarely used" which to me reads like deprecated.
>
> We could instead emit an error that these are deprecated and possibly mention which input sections would be affected.


Hi Ben,

We already had a support of "INFO" (I believe we had a user request for that previously). This patch fixes https://bugs.llvm.org/show_bug.cgi?id=38625
and does not bring anything very new, but just teaches parser about one more possible case.

Also, note that we already support the following:

> .stack address_expression (NOLOAD) :
>  {

but not the

> .stack address_expression (INFO) :
>  {

yet. So I think it is worth to implement both for consistency and few users we have.


https://reviews.llvm.org/D51027





More information about the llvm-commits mailing list