[PATCH] D50972: [InstCombine] Fold icmp ugt/ult (add nuw X, C2), C --> icmp ugt/ult X, (C - C2)

Nicola Zaghen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 21 01:04:48 PDT 2018


Nicola added inline comments.


================
Comment at: test/Transforms/InstCombine/icmp-add.ll:1
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
 ; RUN: opt < %s -instcombine -S | FileCheck %s
----------------
spatel wrote:
> Please commit the tests first. Use this script to auto-generate the current results. Then, update with this patch and auto-generate the new results.
Ok, thanks. I'll create a separate review for it.
Should I also regenerate all the other tests that I'm touching? LoopVectorize/runtime-check.ll is adding a lot on new checks, and some others are changing in InstCombine/icmp-add.ll


Repository:
  rL LLVM

https://reviews.llvm.org/D50972





More information about the llvm-commits mailing list