[PATCH] D50998: [LLD] [COFF] Check the instructions in ARM MOV32T relocations

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

This seems fine, but we generally trust input and don't do too many error checks, so I wonder what is your motivation to add this error check. Was this something you can hit without doing assembly programming?



================
Comment at: COFF/Chunks.cpp:137
+  if ((Op1 & 0xfbf0) != (MOVT ? 0xf2c0 : 0xf240))
+    error("Unexpected instruction in " + Twine(MOVT ? "MOVT" : "MOVW") +
+          " instruction in MOV32T relocation");
----------------
Error messages should start with a lowercase letter.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D50998