[PATCH] D50890: [NFC] Factor out predecessors collection into a separate method
Max Kazantsev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 21 00:16:02 PDT 2018
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340250: [NFC] Factor out predecessors collection into a separate method (authored by mkazantsev, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50890?vs=161205&id=161649#toc
Repository:
rL LLVM
https://reviews.llvm.org/D50890
Files:
llvm/trunk/include/llvm/Analysis/MustExecute.h
llvm/trunk/lib/Analysis/MustExecute.cpp
Index: llvm/trunk/lib/Analysis/MustExecute.cpp
===================================================================
--- llvm/trunk/lib/Analysis/MustExecute.cpp
+++ llvm/trunk/lib/Analysis/MustExecute.cpp
@@ -98,19 +98,13 @@
return SimpleCst->isAllOnesValue();
}
-
-bool LoopSafetyInfo::allLoopPathsLeadToBlock(const Loop *CurLoop,
- const BasicBlock *BB,
- const DominatorTree *DT) const {
+void LoopSafetyInfo::collectTransitivePredecessors(
+ const Loop *CurLoop, const BasicBlock *BB,
+ SmallPtrSetImpl<const BasicBlock *> &Predecessors) const {
+ assert(Predecessors.empty() && "Garbage in predecessors set?");
assert(CurLoop->contains(BB) && "Should only be called for loop blocks!");
-
- // Fast path: header is always reached once the loop is entered.
if (BB == CurLoop->getHeader())
- return true;
-
- // Collect all transitive predecessors of BB in the same loop. This set will
- // be a subset of the blocks within the loop.
- SmallPtrSet<const BasicBlock *, 4> Predecessors;
+ return;
SmallVector<const BasicBlock *, 4> WorkList;
for (auto *Pred : predecessors(BB)) {
Predecessors.insert(Pred);
@@ -132,6 +126,21 @@
if (Predecessors.insert(PredPred).second)
WorkList.push_back(PredPred);
}
+}
+
+bool LoopSafetyInfo::allLoopPathsLeadToBlock(const Loop *CurLoop,
+ const BasicBlock *BB,
+ const DominatorTree *DT) const {
+ assert(CurLoop->contains(BB) && "Should only be called for loop blocks!");
+
+ // Fast path: header is always reached once the loop is entered.
+ if (BB == CurLoop->getHeader())
+ return true;
+
+ // Collect all transitive predecessors of BB in the same loop. This set will
+ // be a subset of the blocks within the loop.
+ SmallPtrSet<const BasicBlock *, 4> Predecessors;
+ collectTransitivePredecessors(CurLoop, BB, Predecessors);
// Make sure that all successors of all predecessors of BB are either:
// 1) BB,
Index: llvm/trunk/include/llvm/Analysis/MustExecute.h
===================================================================
--- llvm/trunk/include/llvm/Analysis/MustExecute.h
+++ llvm/trunk/include/llvm/Analysis/MustExecute.h
@@ -49,6 +49,13 @@
// may throw.
bool HeaderMayThrow = false; // Same as previous, but specific to loop header
+ /// Collect all blocks from \p CurLoop which lie on all possible paths from
+ /// the header of \p CurLoop (inclusive) to BB (exclusive) into the set
+ /// \p Predecessors. If \p BB is the header, \p Predecessors will be empty.
+ void collectTransitivePredecessors(
+ const Loop *CurLoop, const BasicBlock *BB,
+ SmallPtrSetImpl<const BasicBlock *> &Predecessors) const;
+
public:
// Used to update funclet bundle operands.
DenseMap<BasicBlock *, ColorVector> BlockColors;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50890.161649.patch
Type: text/x-patch
Size: 2968 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180821/d0914635/attachment.bin>
More information about the llvm-commits
mailing list