[PATCH] D50621: [DebugInfo] Fix bug in LiveDebugVariables.

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added inline comments.


================
Comment at: lib/CodeGen/LiveDebugVariables.cpp:597
+        // kinds of debug instructions.
         if (handleDebugValue(*MBBI, Idx)) {
           MBBI = MBB->erase(MBBI);
----------------
I think this should be `(MBBI->isDebugValue() &&  handleDebugValue(*MBBI, Idx))`,  or we need to explicitly check for isDebugValue() at the beginning of handleDebugValue. I don't think we want to see the "Can't handle" debug printouts from handleDebugValue due to calling the function with non DBG_VALUE instructions.


https://reviews.llvm.org/D50621