[PATCH] D51006: LTO: make tempfiles in LTO cache subject to pruning

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 20 15:53:00 PDT 2018


pcc requested changes to this revision.
pcc added a comment.
This revision now requires changes to proceed.

The temporary files are deliberately named differently from the cache entries in order to prevent cache pruners from racing with processes that create cache files. If we allow these deletions it would have the effect of causing the call to `TempFile::keep` to sometimes return no such file or directory, so I'd at least expect to see code handling that case.

Do you know why the temporary files are being left on disk? I wouldn't have expected that to happen because they are being created with delete-on-close.


https://reviews.llvm.org/D51006





More information about the llvm-commits mailing list