[llvm] r340222 - extend binop folds for selects to include true and false binops flag intersection

Michael Berg via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 20 15:26:58 PDT 2018


Author: mcberg2017
Date: Mon Aug 20 15:26:58 2018
New Revision: 340222

URL: http://llvm.org/viewvc/llvm-project?rev=340222&view=rev
Log:
extend binop folds for selects to include true and false binops flag intersection

Summary: This change address bug 38641

Reviewers: spatel, wristow

Reviewed By: spatel

Differential Revision: https://reviews.llvm.org/D50996

Modified:
    llvm/trunk/lib/Transforms/InstCombine/InstCombineSelect.cpp
    llvm/trunk/test/Transforms/InstCombine/select_meta.ll

Modified: llvm/trunk/lib/Transforms/InstCombine/InstCombineSelect.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineSelect.cpp?rev=340222&r1=340221&r2=340222&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/InstCombine/InstCombineSelect.cpp (original)
+++ llvm/trunk/lib/Transforms/InstCombine/InstCombineSelect.cpp Mon Aug 20 15:26:58 2018
@@ -355,7 +355,8 @@ Instruction *InstCombiner::foldSelectOpO
   Value *Op1 = MatchIsOpZero ? NewSI : MatchOp;
   if (auto *BO = dyn_cast<BinaryOperator>(TI)) {
     BinaryOperator *NewBO = BinaryOperator::Create(BO->getOpcode(), Op0, Op1);
-    NewBO->copyIRFlags(BO);
+    NewBO->copyIRFlags(TI);
+    NewBO->andIRFlags(FI);
     return NewBO;
   }
   if (auto *TGEP = dyn_cast<GetElementPtrInst>(TI)) {

Modified: llvm/trunk/test/Transforms/InstCombine/select_meta.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/select_meta.ll?rev=340222&r1=340221&r2=340222&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/InstCombine/select_meta.ll (original)
+++ llvm/trunk/test/Transforms/InstCombine/select_meta.ll Mon Aug 20 15:26:58 2018
@@ -7,12 +7,12 @@ define i32 @foo(i32) local_unnamed_addr
 ; CHECK-LABEL: @foo(
 ; CHECK-NEXT:    [[TMP2:%.*]] = icmp sgt i32 %0, 2
 ; CHECK-NEXT:    [[DOTV:%.*]] = select i1 [[TMP2]], i32 20, i32 -20, !prof ![[$MD1:[0-9]+]]
-; CHECK-NEXT:    [[TMP3:%.*]] = add nsw i32 [[DOTV]], %0
+; CHECK-NEXT:    [[TMP3:%.*]] = add i32 [[DOTV]], %0
 ; CHECK-NEXT:    ret i32 [[TMP3]]
 ;
   %2 = icmp sgt i32 %0, 2
   %3 = add nsw i32 %0, 20
-  %4 = add nsw i32 %0, -20
+  %4 = add i32 %0, -20
   select i1 %2, i32 %3, i32 %4, !prof !1
   ret i32 %5
 }




More information about the llvm-commits mailing list