[PATCH] D50893: [GVN] Assign new value number to calls reading memory, if there is no MemDep info.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 20 15:24:10 PDT 2018


efriedma added a comment.

PassManagerBuilder supports a boolean DisableGVNLoadPRE, but it looks like it's only hooked up to an actual user option if you're using LTO.  You could add an option to GVN.cpp to override the default, to allow testing this codepath, I guess.



================
Comment at: lib/Transforms/Scalar/GVN.cpp:396
     return e;
   } else if (AA->onlyReadsMemory(C)) {
     Expression exp = createExpr(C);
----------------
Probably simpler to check `MD && AA->onlyReadsMemory(C)` here.


https://reviews.llvm.org/D50893





More information about the llvm-commits mailing list