[PATCH] D50946: [InstCombine] Add splat vector constant support to foldICmpAddOpConst.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 20 15:02:22 PDT 2018


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

Not sure how good the scalar test coverage is, but we can do better for the vector tests:

1. The 'ugt' test is getting transformed to 'ult', so there's not actually a test for 'ugt'?
2. Add a test for the 'sgt' case?

Code LGTM.


Repository:
  rL LLVM

https://reviews.llvm.org/D50946





More information about the llvm-commits mailing list