[PATCH] D50913: [FPEnv] Don't need copysign/fabs/fneg constrained intrinsics

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 20 14:23:44 PDT 2018


spatel added a comment.

In https://reviews.llvm.org/D50913#1206373, @cameron.mcinally wrote:

> Cool, I like that idea. I'll let this sit for a day or so to see if there are further comments. If not, I'll start a discussion on llvm-dev for a wider audience.


I think fneg as an IR instruction or intrinsic has come up for discussion before, but I don't know why it wasn't implemented at the time. An intrinsic is the lighter weight solution and would line up with the similar:
http://llvm.org/docs/LangRef.html#llvm-copysign-intrinsic
http://llvm.org/docs/LangRef.html#llvm-fabs-intrinsic

Any reason to prefer an actual instruction over an intrinsic?


Repository:
  rL LLVM

https://reviews.llvm.org/D50913





More information about the llvm-commits mailing list