[PATCH] D45300: Update MemorySSA BasicBlockUtils.

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: jvesely.

I think just one patch is fine for this kind of API update.

If you want to test any of these changes, you can do so by writing a unittest, but we don't have an amazing track record here. See the *single* test we have in `unittests/Transforms/Utils/BasicBlockUtils.cpp`. While adding coverage there is good, if it proves hard to do or would require a bunch of work, I'm happy with relying on the usage in the subsequent patches.

The code LGTM. If you can't easily add a unittest, feel free to submit as-is. If you can add a test, I'm happy to look at that too.


Repository:
  rL LLVM

https://reviews.llvm.org/D45300