[llvm] r339091 - [lit, tests] Fix failing lit test: shtest-format.py

[via llvm-commits]

Hi Hans,

Can we have this change merged into 7.0? Our internal builder for the 7.0 branch uses python 2 and is hitting this issue.

Douglas Yung

> -----Original Message-----
> From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On
> Behalf Of Stella Stamenova via llvm-commits
> Sent: Monday, August 06, 2018 21:09
> To: llvm-commits at lists.llvm.org
> Subject: [llvm] r339091 - [lit, tests] Fix failing lit test: shtest-
> format.py
> 
> Author: stella.stamenova
> Date: Mon Aug  6 21:08:46 2018
> New Revision: 339091
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=339091&view=rev
> Log:
> [lit, tests] Fix failing lit test: shtest-format.py
> 
> Summary:
> The problem here is that on windows double quotes are used for paths
> (usually) while single quotes are not. This is not generally a problem
> for the tests because the lit infrastructure tends to treat both the
> same. One (and possibly only) exception is when some tests are run in
> an external shell such as some of the shtest-format tests. In this case
> on windows the path to python was not created correctly because it had
> single quotes and the test failed.
> 
> This same test is already failing with python 3 which is why our
> testing missed the new failure. This patch will take care of the
> immediate failure with python 2 and I'll send a follow up for the
> python 3 failure.
> 
> Reviewers: asmith, zturner
> 
> Subscribers: delcypher, llvm-commits
> 
> Differential Revision: https://reviews.llvm.org/D50373
> 
> Modified:
>     llvm/trunk/utils/lit/tests/Inputs/shtest-format/lit.cfg
> 
> Modified: llvm/trunk/utils/lit/tests/Inputs/shtest-format/lit.cfg
> URL: http://llvm.org/viewvc/llvm-
> project/llvm/trunk/utils/lit/tests/Inputs/shtest-
> format/lit.cfg?rev=339091&r1=339090&r2=339091&view=diff
> =======================================================================
> =======
> --- llvm/trunk/utils/lit/tests/Inputs/shtest-format/lit.cfg (original)
> +++ llvm/trunk/utils/lit/tests/Inputs/shtest-format/lit.cfg Mon Aug  6
> 21:08:46 2018
> @@ -6,4 +6,4 @@ config.test_source_root = None
>  config.test_exec_root = None
>  config.target_triple = 'x86_64-unknown-unknown'
>  config.available_features.add('a-present-feature')
> -config.substitutions.append(('%{python}', "'%s'" % (sys.executable)))
> +config.substitutions.append(('%{python}', '"%s"' % (sys.executable)))
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits