[PATCH] D47814: Teach libc++ to use native NetBSD's max_align_t

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 20 13:21:35 PDT 2018


chandlerc added a comment.

In https://reviews.llvm.org/D47814#1206372, @krytarowski wrote:

> If there are no more comments, I will land this by the end of this week.


Just for the record, this is not OK and not how LLVM's code review works.

You can and must wait for review. I think Joerg already marked this as accepted, but it didn't send out an email[1]. That means it got reviewed, so all is good here, but I wanted to make it clear to others on the list what the expectations are here.

-Chandler

[1]: FYI, it's useful to put *some* text in the text box when marking a revision as accepted on Phab so that it will in fact send email. I typically put "LGTM" or a brief thank-you note to the author.


Repository:
  rL LLVM

https://reviews.llvm.org/D47814





More information about the llvm-commits mailing list