[PATCH] D50930: Move Itanium demangler implementation into a header file and add visitation support.

[Richard Smith - zygoloid via Phabricator via llvm-commits]

rsmith added inline comments.


================
Comment at: lib/Demangle/ItaniumDemangle.cpp:236-238
+//===----------------------------------------------------------------------===//
+// Code beyond this point should not be synchronized with libc++abi.
+//===----------------------------------------------------------------------===//
----------------
erik.pilkington wrote:
> I think this comment is too high: initializeOutputStream() and BumpPointerAllocator are both used in the libcxxabi version.
Right, sorry. I was thinking about what I plan to do next, which is to make the LLVM version use `llvm::BumpPtrAllocator`, but until / unless that happens I agree.


Repository:
  rL LLVM

https://reviews.llvm.org/D50930