[PATCH] D50988: Remove Darwin support from POWER backend.

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 20 13:08:22 PDT 2018


MatzeB added a comment.

In https://reviews.llvm.org/D50988#1206371, @kbarton wrote:

> In https://reviews.llvm.org/D50988#1206363, @MatzeB wrote:
>
> > Actually can you explain the removal of `llvm/test/tools/dsymutil/PowerPC/sibling.test`?
>
>
> I had an email conversation with @JDevlieghere regarding this test. Someone suggested a test based on an old version of llvm-gcc from an old Powerbook G4, which is how this test was created. That was the only reason for this being a PowerPC test.
>
> I tried generating an alternate test using a new GCC on a ppc64le machine, but the test caused an Assert failure in dsymutil. Jonas is looking at. In the meantime, he said this specific test should not block this patch.
>
> If you have another idea for generating an equivalent test, I'm happy to do it.


I just think the commit message should mention why it was removed (no need for a replacement if you already discussed this with @JDevlieghere).


Repository:
  rL LLVM

https://reviews.llvm.org/D50988





More information about the llvm-commits mailing list