[PATCH] D50986: [ShrinkWrap] Don't put pseudo-instrs which use $sp before prologue setup

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 20 13:08:14 PDT 2018


thegameg added reviewers: thegameg, MatzeB.
thegameg added a comment.

This looks ok, but I am not sure the `FrameSetup` flag was made to be used in this way.

Would it make more sense to add SP as an implicit use to the instruction instead? I believe this is how things are usually modelled now, but I might be wrong.



================
Comment at: test/CodeGen/Mips/shrink-wrap-buildpairf64-extractelementf64.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+
----------------
Can you please add a MIR test with `-start-before shrink-wrap -stop-after prologepilog` instead of an IR test?


Repository:
  rL LLVM

https://reviews.llvm.org/D50986





More information about the llvm-commits mailing list