[PATCH] D50988: Remove Darwin support from POWER backend.

Mon Aug 20 12:20:06 PDT 2018

kbarton created this revision.
kbarton added reviewers: power-llvm-team, hfinkel, echristo, JDevlieghere.
Herald added subscribers: hiraditya, eraman, nemanjai, sanjoy, qcolombet, MatzeB.

This is the first in a series of patches to remove darwin support from the PowerPC backend. This patch issues an error message if Darwin support is attempted. It also cleans up all existing test cases, either converting the test to use an alternative triple or removing the test if the coverage is no longer needed.

Once this patch lands, subsequent patches can be committed that actively remove the Darwin code paths from POWER backend. Since these paths will be dead code at that point, the cleanup can be done using post-commit reviews when applicable.

There is a companion patch for Clang, which fixes test cases in Clang. I will open another review for those changes and link to this revision.

Repository:
  rL LLVM

https://reviews.llvm.org/D50988

Files:
  llvm/lib/Target/PowerPC/PPCTargetMachine.cpp
  llvm/test/Analysis/BasicAA/2006-11-03-BasicAAVectorCrash.ll
  llvm/test/CodeGen/PowerPC/2005-11-30-vastart-crash.ll
  llvm/test/CodeGen/PowerPC/2006-01-11-darwin-fp-argument.ll
  llvm/test/CodeGen/PowerPC/2006-04-05-splat-ish.ll
  llvm/test/CodeGen/PowerPC/2006-09-28-shift_64.ll
  llvm/test/CodeGen/PowerPC/2006-10-17-brcc-miscompile.ll
  llvm/test/CodeGen/PowerPC/2007-01-15-AsmDialect.ll
  llvm/test/CodeGen/PowerPC/2007-02-16-AlignPacked.ll
  llvm/test/CodeGen/PowerPC/2007-02-16-InlineAsmNConstraint.ll
  llvm/test/CodeGen/PowerPC/2007-02-23-lr-saved-twice.ll
  llvm/test/CodeGen/PowerPC/2007-04-24-InlineAsm-I-Modifier.ll
  llvm/test/CodeGen/PowerPC/2007-04-30-InlineAsmEarlyClobber.ll
  llvm/test/CodeGen/PowerPC/2007-05-03-InlineAsm-S-Constraint.ll
  llvm/test/CodeGen/PowerPC/2007-05-14-InlineAsmSelectCrash.ll
  llvm/test/CodeGen/PowerPC/2007-05-22-tailmerge-3.ll
  llvm/test/CodeGen/PowerPC/2007-05-30-dagcombine-miscomp.ll
  llvm/test/CodeGen/PowerPC/2007-09-08-unaligned.ll
  llvm/test/CodeGen/PowerPC/2007-09-12-LiveIntervalsAssert.ll
  llvm/test/CodeGen/PowerPC/2007-10-21-LocalRegAllocAssert.ll
  llvm/test/CodeGen/PowerPC/2007-10-21-LocalRegAllocAssert2.ll
  llvm/test/CodeGen/PowerPC/2007-11-04-CoalescerCrash.ll
  llvm/test/CodeGen/PowerPC/2007-11-16-landingpad-split.ll
  llvm/test/CodeGen/PowerPC/2008-02-05-LiveIntervalsAssert.ll
  llvm/test/CodeGen/PowerPC/2008-02-09-LocalRegAllocAssert.ll
  llvm/test/CodeGen/PowerPC/2008-03-05-RegScavengerAssert.ll
  llvm/test/CodeGen/PowerPC/2008-03-26-CoalescerBug.ll
  llvm/test/CodeGen/PowerPC/2008-04-10-LiveIntervalCrash.ll
  llvm/test/CodeGen/PowerPC/2008-04-16-CoalescerBug.ll
  llvm/test/CodeGen/PowerPC/2008-04-23-CoalescerCrash.ll
  llvm/test/CodeGen/PowerPC/2008-05-01-ppc_fp128.ll
  llvm/test/CodeGen/PowerPC/2008-07-15-Bswap.ll
  llvm/test/CodeGen/PowerPC/2008-07-15-Fabs.ll
  llvm/test/CodeGen/PowerPC/2008-07-15-SignExtendInreg.ll
  llvm/test/CodeGen/PowerPC/2008-07-17-Fneg.ll
  llvm/test/CodeGen/PowerPC/2008-07-24-PPC64-CCBug.ll
  llvm/test/CodeGen/PowerPC/2008-09-12-CoalescerBug.ll
  llvm/test/CodeGen/PowerPC/2008-10-17-AsmMatchingOperands.ll
  llvm/test/CodeGen/PowerPC/2008-10-31-PPCF128Libcalls.ll
  llvm/test/CodeGen/PowerPC/2008-12-02-LegalizeTypeAssert.ll
  llvm/test/CodeGen/PowerPC/2009-01-16-DeclareISelBug.ll
  llvm/test/CodeGen/PowerPC/2009-03-17-LSRBug.ll
  llvm/test/CodeGen/PowerPC/2009-05-28-LegalizeBRCC.ll
  llvm/test/CodeGen/PowerPC/2009-08-17-inline-asm-addr-mode-breakage.ll
  llvm/test/CodeGen/PowerPC/2009-09-18-carrybit.ll
  llvm/test/CodeGen/PowerPC/2009-11-15-ProcImpDefsBug.ll
  llvm/test/CodeGen/PowerPC/2009-11-25-ImpDefBug.ll
  llvm/test/CodeGen/PowerPC/2010-02-04-EmptyGlobal.ll
  llvm/test/CodeGen/PowerPC/2010-02-12-saveCR.ll
  llvm/test/CodeGen/PowerPC/2010-03-09-indirect-call.ll
  llvm/test/CodeGen/PowerPC/2010-04-01-MachineCSEBug.ll
  llvm/test/CodeGen/PowerPC/2010-05-03-retaddr1.ll
  llvm/test/CodeGen/PowerPC/2010-12-18-PPCStackRefs.ll
  llvm/test/CodeGen/PowerPC/2011-12-05-NoSpillDupCR.ll
  llvm/test/CodeGen/PowerPC/2011-12-06-SpillAndRestoreCR.ll
  llvm/test/CodeGen/PowerPC/Atomics-64.ll
  llvm/test/CodeGen/PowerPC/Frames-alloca.ll
  llvm/test/CodeGen/PowerPC/Frames-large.ll
  llvm/test/CodeGen/PowerPC/Frames-small.ll
  llvm/test/CodeGen/PowerPC/LargeAbsoluteAddr.ll
  llvm/test/CodeGen/PowerPC/addc.ll
  llvm/test/CodeGen/PowerPC/align.ll
  llvm/test/CodeGen/PowerPC/anon_aggr.ll
  llvm/test/CodeGen/PowerPC/asm-dialect.ll
  llvm/test/CodeGen/PowerPC/atomic-1.ll
  llvm/test/CodeGen/PowerPC/atomics-fences.ll
  llvm/test/CodeGen/PowerPC/atomics-indexed.ll
  llvm/test/CodeGen/PowerPC/atomics.ll
  llvm/test/CodeGen/PowerPC/available-externally.ll
  llvm/test/CodeGen/PowerPC/branch-opt.ll
  llvm/test/CodeGen/PowerPC/byval-aliased.ll
  llvm/test/CodeGen/PowerPC/coal-sections.ll
  llvm/test/CodeGen/PowerPC/coalesce-ext.ll
  llvm/test/CodeGen/PowerPC/combine_loads_from_build_pair.ll
  llvm/test/CodeGen/PowerPC/compare-duplicate.ll
  llvm/test/CodeGen/PowerPC/compare-simm.ll
  llvm/test/CodeGen/PowerPC/darwin-labels.ll
  llvm/test/CodeGen/PowerPC/debuginfo-stackarg.ll
  llvm/test/CodeGen/PowerPC/empty-functions.ll
  llvm/test/CodeGen/PowerPC/fabs.ll
  llvm/test/CodeGen/PowerPC/fsqrt.ll
  llvm/test/CodeGen/PowerPC/hidden-vis-2.ll
  llvm/test/CodeGen/PowerPC/hidden-vis.ll
  llvm/test/CodeGen/PowerPC/indirect-hidden.ll
  llvm/test/CodeGen/PowerPC/indirectbr.ll
  llvm/test/CodeGen/PowerPC/int-fp-conv-0.ll
  llvm/test/CodeGen/PowerPC/ispositive.ll
  llvm/test/CodeGen/PowerPC/itofp128.ll
  llvm/test/CodeGen/PowerPC/longdbl-truncate.ll
  llvm/test/CodeGen/PowerPC/lsr-postinc-pos.ll
  llvm/test/CodeGen/PowerPC/mask64.ll
  llvm/test/CodeGen/PowerPC/named-reg-alloc-r0.ll
  llvm/test/CodeGen/PowerPC/named-reg-alloc-r1-64.ll
  llvm/test/CodeGen/PowerPC/named-reg-alloc-r1.ll
  llvm/test/CodeGen/PowerPC/named-reg-alloc-r13-64.ll
  llvm/test/CodeGen/PowerPC/named-reg-alloc-r13.ll
  llvm/test/CodeGen/PowerPC/named-reg-alloc-r2-64.ll
  llvm/test/CodeGen/PowerPC/named-reg-alloc-r2.ll
  llvm/test/CodeGen/PowerPC/no-dead-strip.ll
  llvm/test/CodeGen/PowerPC/or-addressing-mode.ll
  llvm/test/CodeGen/PowerPC/ppc-prologue.ll
  llvm/test/CodeGen/PowerPC/ppc32-i1-vaarg.ll
  llvm/test/CodeGen/PowerPC/ppcf128-1-opt.ll
  llvm/test/CodeGen/PowerPC/ppcf128-1.ll
  llvm/test/CodeGen/PowerPC/private.ll
  llvm/test/CodeGen/PowerPC/retaddr.ll
  llvm/test/CodeGen/PowerPC/rlwimi-keep-rsh.ll
  llvm/test/CodeGen/PowerPC/seteq-0.ll
  llvm/test/CodeGen/PowerPC/stack-protector.ll
  llvm/test/CodeGen/PowerPC/stfiwx.ll
  llvm/test/CodeGen/PowerPC/stubs.ll
  llvm/test/CodeGen/PowerPC/tailcallpic1.ll
  llvm/test/CodeGen/PowerPC/varargs.ll
  llvm/test/CodeGen/PowerPC/vec_auto_constant.ll
  llvm/test/CodeGen/PowerPC/vec_buildvector_loadstore.ll
  llvm/test/CodeGen/PowerPC/vec_misaligned.ll
  llvm/test/CodeGen/PowerPC/vec_shuffle.ll
  llvm/test/CodeGen/PowerPC/vec_splat_constant.ll
  llvm/test/CodeGen/PowerPC/vector-merge-store-fp-constants.ll
  llvm/test/CodeGen/PowerPC/vrsave-spill.ll
  llvm/test/CodeGen/PowerPC/weak_def_can_be_hidden.ll
  llvm/test/CodeGen/SystemZ/combine_loads_from_build_pair.ll
  llvm/test/Transforms/GlobalOpt/2007-11-09-GEP-GEP-Crash.ll
  llvm/test/Transforms/IndVarSimplify/dangling-use.ll
  llvm/test/Transforms/InstCombine/2007-05-14-Crash.ll
  llvm/test/Transforms/InstCombine/2007-10-31-RangeCrash.ll
  llvm/test/Transforms/SCCP/2006-10-23-IPSCCP-Crash.ll
  llvm/test/Transforms/SCCP/2006-12-04-PackedType.ll
  llvm/test/Transforms/SimplifyCFG/2006-08-03-Crash.ll
  llvm/test/tools/dsymutil/PowerPC/lit.local.cfg
  llvm/test/tools/dsymutil/PowerPC/sibling.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50988.161531.patch
Type: text/x-patch
Size: 122593 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180820/f566168a/attachment-0001.bin>