[PATCH] D50975: [FPEnv] Support constrained FREM intrinsic

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 20 11:39:01 PDT 2018


cameron.mcinally added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:4203
     break;
   case ISD::FADD:
     Results.push_back(ExpandFPLibCall(Node, RTLIB::ADD_F32, RTLIB::ADD_F64,
----------------
craig.topper wrote:
> Should STRICT_FADD be here? Same question for MUL and SUB
Good call. I'll add those in and see if I can find a test case that expands on x86. Maybe FP128 or something...


Repository:
  rL LLVM

https://reviews.llvm.org/D50975





More information about the llvm-commits mailing list