[PATCH] D50983: AMDGPU: Partially move target handling code from clang to TargetParser

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 20 11:34:50 PDT 2018


arsenm created this revision.
arsenm added reviewers: rampitec, kzhuravl, yaxunl.
Herald added subscribers: t-tye, tpr, dstuttard, wdng.

A future change in clang necessitates access of this information
from the driver, so move this into a common place.

      

Try to mimic something resembling the API the other targets are
using here.

     

One thing I'm uncertain about is how to split amdgcn and r600
handling. Here I've mostly duplicated the functions for each,
while keeping the same enums. I think this is a bit awkward
for the features which don't matter for amdgcn.

      

It's also a bit messy that this isn't a complete set of
subtarget features. This is just the minimum set needed
for the driver code. For example building the list of
subtarget feature names is still in clang.


https://reviews.llvm.org/D50983

Files:
  include/llvm/Support/TargetParser.h
  lib/Support/TargetParser.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50983.161521.patch
Type: text/x-patch
Size: 8633 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180820/08db63ba/attachment.bin>


More information about the llvm-commits mailing list