[PATCH] D50968: [AST] make a static local variable in a hidden inlined fuction visible

[Jinsong Ji via Phabricator via llvm-commits]

jsji resigned from this revision.
jsji removed a reviewer: jsji.
jsji added inline comments.


================
Comment at: lib/AST/Decl.cpp:1272
+      assert(cast<VarDecl>(D)->isStaticLocal());
+      return LinkageInfo(VisibleNoLinkage, DefaultVisibility, false);
+    }
----------------
Is it overreaction here if we always return "DefaultVisibility"? Is it possible that the visibility of this static was already hidden without -fvisibility-inlines-hidden?

Maybe we should consider avoid calling mergeVisibility for local static only?


https://reviews.llvm.org/D50968