[PATCH] D50657: Add R_HEX_32 relocation support

Sid Manning via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 20 06:13:17 PDT 2018


sidneym added inline comments.


================
Comment at: lld/trunk/ELF/Arch/Hexagon.cpp:132
+  case R_HEX_32:
+    or32le(Loc, applyMask(0xffffffff, Val));
+    break;
----------------
ruiu wrote:
> `applyMask(0xffffffff, ...)` seems to be a no-op. Can you just use `Val`?
Sure, I'll update yet to be committed https://reviews.llvm.org/D50603 with this change


Repository:
  rL LLVM

https://reviews.llvm.org/D50657





More information about the llvm-commits mailing list