[PATCH] D50891: [LICM] Hoist guards from non-header blocks

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev planned changes to this revision.
mkazantsev added inline comments.


================
Comment at: lib/Analysis/MustExecute.cpp:193
+  // to memory.
+  // TODO: Cache this in a manner like ICF?
+  for (auto *Pred : Predecessors)
----------------
fedor.sergeev wrote:
> Since current usage of this interface is limited to invariant guards only it should not be a pressing problem compile-time wise.
> But it is worth to at least consider our options.
> Did you think about extending ICF to track this information as well?
> 
Planning to make MemoryWriteTracking based on https://reviews.llvm.org/D50954


https://reviews.llvm.org/D50891