[PATCH] D50582: ValueTracking: Handle more instructions in isKnownNeverNaN

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Analysis/ValueTracking.cpp:2921-2923
   // TODO: Handle instructions and potentially recurse like other 'isKnown'
   // functions. For example, the result of sitofp is never NaN.
 
----------------
arsenm wrote:
> spatel wrote:
> > spatel wrote:
> > > Remove stale comment.
> > Comment is still here. Also, we should have tests for sitofp/uitofp.
> The tests are there for sitofp/uitofp, just apparently somehow the fcmp ord was already optimizing away before
It looks like foldFCmpIntToFPConst specifically handles the case of these with an fcmp ord


https://reviews.llvm.org/D50582