[PATCH] D50899: [LLD][ELF] - Check the architecture of lazy objects earlier.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 19 22:00:48 PDT 2018


ruiu added inline comments.


================
Comment at: ELF/InputFiles.cpp:1265
+  if (getELFKind(this->MB) != Config->EKind)
+    error(this->MB.getBufferIdentifier() + " has incompatible ELF kind");
+  else
----------------
`"incompatible file: " + this->MB.getBufferIdentifier()` is perhaps better.


================
Comment at: ELF/InputFiles.cpp:1267
+  else
+    addElfSymbols<ELFT>();
 }
----------------
You can inline this function now.


https://reviews.llvm.org/D50899





More information about the llvm-commits mailing list