[PATCH] D50940: [sanitizer] Change Mmap*NoAccess to return MMAP_FAILED (~(uptr)0) on error

Kristina Brooks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 19 06:38:48 PDT 2018


kristina added a comment.

I would expect it to just forward the return code from the original call since sanitizes already abstract away a lot of things, having more even more abstractions internally seems over the top as they're not public interfaces. I think it's best to fix the incorrect uses and perhaps document it in a more obvious way.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D50940





More information about the llvm-commits mailing list